Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Refactor get start card at new home page #7920

Merged
merged 8 commits into from
Sep 3, 2024
Merged

[Workspace] Refactor get start card at new home page #7920

merged 8 commits into from
Sep 3, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Refactor get start card at new home page according the latest ui design.

The card icon will been update as the followed commit.

Issues Resolved

Screenshot

2024-08-29.23.15.27.mp4

Testing the changes

Changelog

  • refactor: [Workspace] Refactor get start card at new home page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
refactor started card
641df30 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
b291ef0 
…oards into 2.17/refactor-get-started-card
@yubonluo
refactor new home page get start card
bade6eb 
Signed-off-by: yubonluo <yubonluo@amazon.com>
opensearch-changeset-bot bot and others added 3 commits August 29, 2024 15:18
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7920 created/updated
81f8534
@yubonluo
revert code
571aad6 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Merge branch '2.17/refactor-get-started-card' of github.com:yubonluo/…
ceaaadd 
…OpenSearch-Dashboards into 2.17/refactor-get-started-card
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (76de9a3) to head (2f9179d).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...nents/home_get_start_card/setup_get_start_card.tsx 81.81% 3 Missing and 1 partial ⚠️
...blic/components/card_container/card_embeddable.tsx 0.00% 0 Missing and 1 partial ⚠️
...nt_management/public/components/section_render.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7920      +/-   ##
==========================================
- Coverage   64.33%   64.33%   -0.01%     
==========================================
  Files        3677     3678       +1     
  Lines       81206    81202       -4     
  Branches    12946    12943       -3     
==========================================
- Hits        52243    52238       -5     
  Misses      25750    25750              
- Partials     3213     3214       +1
Flag Coverage Δ
Linux_1 30.74% <86.95%> (-0.01%) ⬇️
Linux_2 56.19% <ø> (ø)
Linux_3 40.60% <0.00%> (-0.01%) ⬇️
Linux_4 31.40% <0.00%> (+<0.01%) ⬆️
Windows_1 30.76% <86.95%> (-0.01%) ⬇️
Windows_2 56.14% <ø> (ø)
Windows_3 40.61% <0.00%> (-0.01%) ⬇️
Windows_4 31.40% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

src/plugins/workspace/public/components/home_get_start_card/use_case_card_title.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/home_get_start_card/use_case_card_title.tsx Outdated Show resolved Hide resolved
@yubonluo
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
b6e5bc1 
…oards into 2.17/refactor-get-started-card
@yubonluo
optimize the code
2f9179d 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit d13007a into opensearch-project:main Sep 3, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Refactor get start card at new home page (#7920)
69c9e7f 
* refactor started card

Signed-off-by: yubonluo <yubonluo@amazon.com>

* refactor new home page get start card

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7920 created/updated

* revert code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d13007a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 3, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 3, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Refactor get start card at new home page (#7920) (#7965)
b1d7ee6 
* refactor started card



* refactor new home page get start card



* Changeset file for PR #7920 created/updated

* revert code



* optimize the code



---------



(cherry picked from commit d13007a)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yubonluo @ruanyl @SuZhou-Joe